Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for profiled builds #15

Open
facundominguez opened this issue Feb 21, 2017 · 6 comments
Open

Add support for profiled builds #15

facundominguez opened this issue Feb 21, 2017 · 6 comments

Comments

@facundominguez
Copy link

facundominguez commented Feb 21, 2017

The package inline-java is using ghc-heap-view to discern the types of some ConsClosure values which types are otherwise ignored at runtime.

This is likely to change soon, but in the meantime, the dependency on ghc-heap-view prevents any user of inline-java to make profiled builds.

What's involved in making ghc-heap-view work with the profiling RTS?

@facundominguez
Copy link
Author

cc @mboes

@nomeata
Copy link
Owner

nomeata commented Feb 21, 2017

@erikd is trying to get this code into GHC proper. This is being discussed at https://phabricator.haskell.org/D3055, so maybe raise your point there too.

What's involved in making ghc-heap-view work with the profiling RTS?

I’m not completely certain on all the details. Probably just a way of detecting that we are using profiling, and adjusting to the different closure layout.

@erikd
Copy link
Contributor

erikd commented Feb 22, 2017

The idea of adding ghc-heap-view to GHC has turned into a bit of a rabbit hole.

Currently, ghc-heap-view doesn't support unlifted types and it looks like closure types like MUT_ARR_* contain Array# a where the Array# is unlifted, but the a may be lifted. I think its possible to support this, but it doesn't seem trivial.

@jberryman
Copy link
Contributor

I'm only using the assertNF family of functions. It seems as though that could be moved into its own library and simply disabled with a warning when there is a profile build, somehow.

@anka-213
Copy link

Since the code has now been merged into GHC and this package now depends on it, can the check be removed now or is there any other problems for profiled builds?

@nomeata
Copy link
Owner

nomeata commented May 14, 2022

I actually don't know. You could try :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants