Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing 'rewrap' and 'keys' command #198

Open
luca648 opened this issue Mar 22, 2022 · 1 comment
Open

Missing 'rewrap' and 'keys' command #198

luca648 opened this issue Mar 22, 2022 · 1 comment

Comments

@luca648
Copy link

luca648 commented Mar 22, 2022

Hello guys,

First of all I would like to thank you for providing this nice package.

I am opening this ticket because while using it for a typescript project I noticed that the commands rewrap and keys were missing. I then tried to extend the commands set thanks to the commands parameter of the lib but I encountered the two following difficulties :

  • The builtin commands object do not seem to be exported making it uncomfortable for someone to extend it : I had to copy the file to my project.

  • The type of the parameter is Array<{ method: string, path: string, scheme: any }> while the main function seems to expect an object obliging me to cast for the build to pass.

    That'd be great If you could take a look.

Regards,

Luca

@aviadhahami
Copy link
Collaborator

Hey @luca648 :)
I understand the issues you're encountering; Do you mind PRing these changes, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants