refactor: Wallet owns its update stream #51
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, calling
Wallet::get_update_stream()
spawned a new task on every call. Now, instead, theWallet
owns a single task that polls the federation views, andget_update_stream()
simply creates a new stream that watches for the views that are produced by that single task. This also allowed us to addWallet::force_update_view()
which tells theWallet
-owned task to immediately produce the next value rather than waiting, and waits for the latest value to be produced. This ensures thatforce_update_view()
doesn't complete until all streams returned byget_update_stream()
have the latest view queued up. We then callforce_update_view()
at the end of all publicWallet
functions that mutate client state. This ensures that the GUI received the latest view from theWallet
view stream before an action function completes.