Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node v12+ Requires TLS min v1 #136

Open
niftylettuce opened this issue Dec 5, 2019 · 6 comments
Open

Node v12+ Requires TLS min v1 #136

niftylettuce opened this issue Dec 5, 2019 · 6 comments

Comments

@niftylettuce
Copy link
Contributor

We need to add the option minVersion: 'TLSv1' to

@niftylettuce
Copy link
Contributor Author

@andris9
Copy link
Member

andris9 commented Dec 5, 2019

Could you test if it works and make a pull request for it?

@niftylettuce
Copy link
Contributor Author

We also need to add secureOptions: crypto.constants.SSL_OP_NO_SSLv3

@andris9
Copy link
Member

andris9 commented Jan 3, 2020

minVersion and secureOptions can not be used at the same time. Using minVersion seems like more reasonable option (as it is simpler). What for would be the SSL_OP_NO_SSLv3 option anyway, seems kind of cryptic?

@niftylettuce
Copy link
Contributor Author

@andris9 here's the config I used: <https://github.com/forwardemail/free-email-forwarding/blob/master/index.js#L144-L151

{
  // ...
  minVersion: 'TLSv1',
  ciphers: tls.getCiphers().map(cipher => cipher.toUpperCase()).join(':'),
  secureOptions: crypto.constants.SSL_OP_NO_SSLv3 | crypto.constants.SSL_OP_NO_SSLv2
}

@niftylettuce
Copy link
Contributor Author

Ref: #136
Ref: #122
Ref: #156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants