Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbortSignal.any: Mark dependent abort signals as aborted before firing events #54466

Closed
shaseley opened this issue Aug 20, 2024 · 2 comments
Closed

AbortSignal.any: Mark dependent abort signals as aborted before firing events #54466

shaseley opened this issue Aug 20, 2024 · 2 comments
Labels
web-standards Issues and PRs related to Web APIs

Comments

@shaseley
Copy link

Spec PR: whatwg/dom#1295
@shaseley shaseley mentioned this issue Aug 20, 2024
Merged
5 tasks
@avivkeller avivkeller added the web-standards Issues and PRs related to Web APIs label Aug 20, 2024
@avivkeller
Copy link
Member

avivkeller commented Aug 20, 2024 •
edited
Loading

See https://whatpr.org/dom/1295/7c494e5...0d05525.html for the diff

CC @nodejs/web-standards

@avivkeller avivkeller mentioned this issue Aug 20, 2024
Closed
@avivkeller
Copy link
Member

The resolution of this issue will make Node.js's AbortController and AbortSignal complaint with WPT.

@jazelly jazelly mentioned this issue Sep 7, 2024
Closed
targos pushed a commit that referenced this issue Oct 4, 2024
@jazelly @targos
lib: propagate aborted state to dependent signals before firing events
f7c3b03 
PR-URL: #54826
Fixes: #54466
Fixes: #54601
Reviewed-By: James M Snell <[email protected]>
louwers pushed a commit to louwers/node that referenced this issue Nov 2, 2024
@jazelly @louwers
lib: propagate aborted state to dependent signals before firing events
63e37d6 
PR-URL: nodejs#54826
Fixes: nodejs#54466
Fixes: nodejs#54601
Reviewed-By: James M Snell <[email protected]>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
@jazelly @tpoisseau
lib: propagate aborted state to dependent signals before firing events
25277fd 
PR-URL: nodejs#54826
Fixes: nodejs#54466
Fixes: nodejs#54601
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web-standards Issues and PRs related to Web APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lib: propagate aborted state to dependent signals before firing events jazelly/node
2 participants
@shaseley @avivkeller