-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: countReset() should dispatch a warning on non-existent counts #20524
Comments
There's no warnings I know of yet in Node 10 (https://nodejs.org/dist/latest-v10.x/docs/api/console.html#console_console_countreset_label_default). How should we proceed with this? |
The spec for |
Sorry for the lack of clarity here in the spec. Right now, step 3 > substep 2 of
for plans to make warning/error reporting more clear and easy to use. I have a PR for the node implementation here, just kinda got buried in other things, I'll try to submit soon! |
The Console Standard specifies that console.countReset() should emit some type of a warning when given a label that has no previous account associated with it. This PR brings node's implementation of console.countReset() up-to-spec and adds a test asserting that a warning is emitted. Fixes: nodejs#20524
We're in the midst of spec'ing
console.countReset()
to give a warning. Currently node's implementation does not give a warning. The spec PR for this is at whatwg/console#133. I imagine this will be really similar to #20442, and I can submit a PR for this really soon. Filing an issue for now.The text was updated successfully, but these errors were encountered: