Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nan.h error on node v0.10.22 #44

Closed
kuno opened this issue Nov 22, 2013 · 2 comments
Closed

nan.h error on node v0.10.22 #44

kuno opened this issue Nov 22, 2013 · 2 comments

Comments

@kuno
Copy link

kuno commented Nov 22, 2013

This is error was found in module geoip, the original issue can be found in here.

Quoted from original issue

We are experiencing a new error (very infrequently) since upgrading to node v0.10.22. The following message is displayed and the process exits immediately.

node: /opt/pre-publish/star/node_modules/orion/node_modules/geoip/node_modules/nan/nan.h:809: bool _NanGetExternalParts(v8::Handle<v8::Value>, const char**, size_t*): Assertion `val->IsString()' failed.
Aborted

I suspect it may have something to do with the infamous WalMart memory leak on closed handles fix.

@kkoopa
Copy link
Collaborator

kkoopa commented Nov 22, 2013

This is likely not a bug in NAN.
The assertion tells that _NanGetExternalParts was called with a non-String handle. This in turn means that NanFromV8String was called with a non-String handle. This should only happen if a geoip::*::lookup, geoip::*::lookupSync or geoip::check was called with a non-String argument.

@kuno
Copy link
Author

kuno commented Jan 13, 2014

Closing.

@kuno kuno closed this as completed Jan 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants