Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of i386 docker images #574

Closed
xzyfer opened this issue Nov 3, 2017 · 4 comments
Closed

Status of i386 docker images #574

xzyfer opened this issue Nov 3, 2017 · 4 comments

Comments

@xzyfer
Copy link

xzyfer commented Nov 3, 2017

The i386 docker images state they are experimental until the resolution of an upstream feature. That feature has since been implemented. Is there an update to the stability status of the i386 docker images?

We would like to start using them to build out x86 gyp binaries for distribution.

@SimenB
Copy link
Member

SimenB commented Nov 4, 2017

@tianon is it enough to update the architectures files? The linked images doesn't seem like they're up to date anyways (last tags pushed 6 months ago)

@tianon
Copy link
Contributor

tianon commented Nov 4, 2017

We'll also need to update

RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
amd64) ARCH='x64';; \
ppc64el) ARCH='ppc64le';; \
s390x) ARCH='s390x';; \
arm64) ARCH='arm64';; \
armhf) ARCH='armv7l';; \
*) echo "unsupported architecture"; exit 1 ;; \
esac \
to reference x86, but yeah, I'd love to see i386 images! (they're really useful in my experience for testing at least basic multiarch support on a pure-amd64 machine)

@SimenB
Copy link
Member

SimenB commented Nov 4, 2017

That stuff is missing from the alpine dockerfile, did #569 actually work?

EDIT: Yes it should, since we compile from source on alpine anyways

SimenB added a commit to SimenB/docker-node that referenced this issue Nov 4, 2017
@tianon
Copy link
Contributor

tianon commented Nov 4, 2017

Yeah, as you noted, Alpine compiles from source thanks to musl:

$ manifest-tool inspect node:alpine | grep Arch
1           -    Arch: amd64
2           -    Arch: arm
3           -    Arch: arm64
4           -    Arch: ppc64le

Edit: s390x fails to build, but that's a separate issue (https://doi-janky.infosiftr.net/job/multiarch/view/images/view/node/job/s390x/job/node/58/console)

SimenB added a commit that referenced this issue Nov 5, 2017
* Add i386 arch support

Fixes #574

* download is x86, not i386

* Remove wheezy from i386 builds

* No alpine-3.4 i386 build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants