Mark time and fs-extra as flaky on linux-ia32 #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CurryKitten thanks for the PR! I just wanted to confirm that you have tested this on your systems and that flag works to set them as flaky? |
|
@thealphanerd Yes - tested on our systems, and the flaky option works. I checked that the specific linux-ia32 part worked by making sure it would still mark as a failure if I changed the flaky option to linux-x64... which it did |
|
landed in 0351ffa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've started running citgm-all across all platforms, and had a bunch of failures that look like they all have issues with millisecond precision time-stamping on linux-32.
I've raised issues already on -
fs-extra jprichardson/node-fs-extra#269
time TooTallNate/node-time#97
vinyl-fs gulpjs/vinyl-fs#208
So have marked fs-extra and time as flaky on linux-ia32 (vinyl-fs already marked flaky in general)