Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Promises, with async/await #30

Open
Cherry opened this issue May 15, 2020 · 0 comments
Open

Add support for Promises, with async/await #30

Cherry opened this issue May 15, 2020 · 0 comments
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@Cherry
Copy link
Member

Cherry commented May 15, 2020

This library is pretty mature now and works really well, but still uses callbacks. There's nothing wrong with callbacks, but a lot of modern code nowadays uses promises via async/await, and having this library conform to that would be ideal.

Things to think about:

  • Should we bump a major version and just remove callbacks entirely?
  • Should we try to support both callbacks and promises?
@Cherry Cherry added enhancement New feature or request help wanted Extra attention is needed labels May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant