Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI pipeline for testing (GitHub Actions) #3

Open
Cherry opened this issue Jun 15, 2019 · 5 comments
Open

Add CI pipeline for testing (GitHub Actions) #3

Cherry opened this issue Jun 15, 2019 · 5 comments
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed

Comments

@Cherry
Copy link
Member

Cherry commented Jun 15, 2019

This includes linting, and then testing on supported Node versions. https://travis-ci.org/ is probably the best idea.

For running the test.js, we need to think about how to do that in a way that won't expose any credentials. Perhaps we need to stub Cloudflare's API as well as http/dns to faux-verify? I'm not sure about the best way to implement this yet.

@Cherry
Copy link
Member Author

Cherry commented Oct 7, 2019

Marking this for hacktoberfest.

We should use GitHub Actions. Please see nodecraft/b2-cloud-storage#14 for an example on what needs to be included (code coverage can be ignored for now).

This could be two PRs - one for adding GitHub actions that simply runs npm test for now, and another one for a testing strategy for test.js

@Cherry Cherry added enhancement New feature or request help wanted Extra attention is needed hacktoberfest labels Oct 7, 2019
@Cherry Cherry changed the title Add CI pipeline for testing Add CI pipeline for testing (GitHub Actions) Oct 7, 2019
@abskmj
Copy link
Contributor

abskmj commented Oct 3, 2020

I can pick this up. I can work on the first PR for adding the Github Action.

@Cherry
Copy link
Member Author

Cherry commented Oct 3, 2020

Thanks @abskmj! Let be know if you have any questions.

@abskmj
Copy link
Contributor

abskmj commented Oct 5, 2020

Hello @Cherry, I have opened a new PR #19 with assumptions. Can you take a look?

@Cherry
Copy link
Member Author

Cherry commented Oct 5, 2020

Looks great, thanks @abskmj!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants