Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seemingly uses two ASN.1 parsers #38

Closed
jonassmedegaard opened this issue Feb 3, 2019 · 1 comment
Closed

seemingly uses two ASN.1 parsers #38

jonassmedegaard opened this issue Feb 3, 2019 · 1 comment

Comments

@jonassmedegaard
Copy link

This module directly uses asn1.js indirectly via @trust/jose <- @trust/webcrypto and via pem-jwk, and also uses asn1 indirectly via @trust/jose <- @trust/webcrypto <- node-rsa <- node-rsa and http-signature <- sshpk<- request <- jsonld <- rdflib.

If correctly guessed (from just looking at the module names!) that those provide same/similar functionality, then it seems worthwhile to refactor to get rid of one of them.

See also anvilresearch/webcrypto#85
@dmitrizagidulin
Copy link
Contributor

pem-jwk has been removed, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonassmedegaard @dmitrizagidulin