Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tabulator to latest version #72

Open
Christian-Me opened this issue Aug 1, 2021 · 7 comments
Open

Upgrade tabulator to latest version #72

Christian-Me opened this issue Aug 1, 2021 · 7 comments

Comments

@Christian-Me
Copy link
Contributor

As "promised" before I'm testing an upgrade of the tabulator lib to the latest version (4.9.3).

Looks fine so far, but ...

I use the datetime formatter (only available via ui_control).
It utilize moment.js AND "moment timezone".

Moment.js is installed and working but moment-timezone not so newDatetime.zt() fails:

tabulator.js line 19039 ...

			var newDatetime = moment(value, inputFormat);

			if (newDatetime.isValid()) {
				return formatterParams.timezone ? newDatetime.tz(formatterParams.timezone).format(outputFormat) : newDatetime.format(outputFormat);
			}

Before digging into unknown territory: @dceejay "Any idea how to get timezone installed / working?"

@dceejay
Copy link
Member

dceejay commented Aug 1, 2021

On vacation, so no idea off the top of my head. ( moment is also deprecated so we dont really want to add more)

@Christian-Me
Copy link
Contributor Author

Have a nice vacation .... no worries!

@bpfel
Copy link

bpfel commented Sep 20, 2021

Hi @Christian-Me,
have you looked further into updating tabulator?
I've been spending some time on realizing that the nice contextMenu option is only available past 4.8 and ui-table is on 4.4.

Best,

Gianni

@Christian-Me
Copy link
Contributor Author

Christian-Me commented Sep 20, 2021

A little bit (linked moment.js) but I ran into new problems: olifolkerd/tabulator#3355

Think they are busy working on 5.0 (or better "hope" they are as the last commit was January!).
Decided to wait for 5.1 ;) to restart this project. I don't have enough time to start hand fixing the code.

One motivation for upgrading was the context menu too. But you can use the context menu node like I do for example here: https://discourse.nodered.org/t/announce-remote-device-table-and-collaboration-wanted/22505

@bpfel
Copy link

bpfel commented Sep 21, 2021

Alright thanks alot for the input!
I've been following your work with tabulator and node red and enjoyed seeing what one can achieve with those.
At the moment I am not really able to contribute but maybe at a later time 👍

@Christian-Me
Copy link
Contributor Author

The 5.0 branch looks not so depressing ;) So I think heading to 5.x is the best way not spending too much time in fixing things which will change soon. Tabulator aka ui-table is one of my favorite widgets ... Only sorry that it only unveils the hole potential if you dive deep and many low code users are left out. But to design a UI able to config tabulator with more features would be at least challenging and you will never find a way to please all and at the same time keep it simple und usable.

@mattaylor
Copy link

Tabulator is currently on 5.1 and has added a ton of new features (refreshFilter!) We are still stuck here on 4.4.
Please can we get this updated.

Thanks
mat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants