How to limit file maxsize and form parse error not handle

[clues]

Hi, this a code in my project:
form.uploadDir = conf.getConf().storageRoot;
form.keepExtensions = true;
form.maxFieldsSize = 1 * 1024;
form.encoding = 'utf-8';

1, The property maxFieldsSize is single file max data size? if is, it's not work.
2, If set uploadDir value is unexist directory, progress can't trigger form.on('error',Fun), will
throw a err and i not catch it. So try catch not work also.

[gabeio]

maxFieldsSize relates to only <input type=text />

Limits the amount of memory all fields together (except files)

try checking file.size for the size being bigger than you want & if it is throw an error...

[luin]

It would be better to check the file size during receiving the file instead of after the file is uploaded, so I consider maxFileSize is necessary.

[gabeio]

you can:

form.on('fileBegin', function(name,file) {
    if(file.size < X){
        throw new error; // this should stop the file upload (maybe before it begins; i don't know the internal part)
    }
})

[clues]

yes,i'm agree with @luin, Nginx upload model and S3 all have this function.
@gabeio
form.on('fileBegin', function(name,file) {
if(file.size < X){
throw new error; // this should stop the file upload (maybe before it begins; i don't know the internal part)
}
})
the file.size is whole file size? i worry only first part of chunks size, if client use header 'Transfer-Encoding',
i'm not familiar with http upload stream

[gabeio]

I believe the browser has to tell the server the size in advanced... and that should be the size. But as for wanting new features the developer/owner of this has kinda abandoned/doesn't have enough time anymore to work on this. Therefore if you want the feature you'll have to implement it yourself. I have just been trying to help out with issues as much as I can because I did like the library until I needed better support myself so I switched to multer and body-parser combo (as multer only does multi-part and body-parser only does basic form data)

[OrangeDog]

Use the fileBegin (to check what the client claims) and progress (to see how much is actually sent) events to limit upload size.
Can either throw, calll form._error or change path to '/dev/null'.

[gabeio]

thank you @OrangeDog for confirming and the addition.

[clues]

Thank all. I have test, 'fileBegin' get the file.size is 0, and 'progress' like to solve the problem, but progress is reference whole form body, i only care about file receivedBytes. So, must implement by myself.

[luin]

@clues I have switched to multer, which is able to limit the file size

[clues]

i add field maxFileSize to form, and add compare code in handlePart function, it work.

[pensierinmusica]

+1 Agree with @luin this should really be provided natively by the formidable library. One must be able to easily limit the max file size! Any progress? I know multer provides this, but I'm using koa-body which relies on formidable.

[addedjacky]

rewrite the onPart function

[rfink]

+1 very much needed for koa-body

[we-zhang]

+1, using koa-body now.

[jaydenseric]

For some time there has been a good pull request that adds max upload size for files; it only needs to be merged: #357.

[xarguments]

AFAIU maxFileSize solves the problem, and the issue can be closed now.
If I'm mistaken, feel free to reopen/comment it. Thanks.