Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in nms4r function map_nms_sites #67

Closed
superjai opened this issue Nov 14, 2020 · 2 comments
Closed

error in nms4r function map_nms_sites #67

superjai opened this issue Nov 14, 2020 · 2 comments
Assignees

Comments

@superjai
Copy link
Collaborator

@bbest There is an error in the nms4r function map_nms_sites. I flagged it with your name in the code itself and here is the link. It isn't a problem at the moment, as it only comes up if certain files are missing (which won't be the case for CINMS - but might be for other regions). Here is the problem reprinted below

    # BEN: note that the following line of code will fail because raw_csv and sites_csv
    # aren't defined anywhere
    if (!file.exists(sites_csv)) make_sites_csv(raw_csv, sites_csv)
@bbest
Copy link
Contributor

bbest commented Nov 20, 2020

This is not fixable in the near term since we don't have the ability to publicly share original MARINe data, but we can caveat this in a Vignette for the nms4r package and in README for the CINMS repo.

@bbest
Copy link
Contributor

bbest commented Dec 8, 2020

Let's close this and describe private data aspects of MARINe rocky intertidal in a vignette #69

@bbest bbest closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants