docs(code): added different languages to test i18n issues #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 323 323
Branches 19 23 +4
=========================================
Hits 323 323 ☔ View full report in Codecov by Sentry. |
Rerbun
force-pushed
the
docs/i18n-code-stories
branch
from
6f95a1c
to
ea7eed5
Compare
16 tasks
Robbert
requested changes
Nov 27, 2024
| @@ -32,3 +32,40 @@ export const Default: Story = { | |||
| children: `import { Code } from '@nl-design-system-candidate/code-react';`, | |||
| }, | |||
| }; | |||
|
|
|||
| export const Arabic: Story = { | |||
| name: 'Arabic (Qalb)', | |||
| children: `// Dies ist ein sehr langer deutscher Codekommentar, der in eine zweite Zeile übergehen könnte und auch einige ziemlich lange Wörter enthält`, | ||
| lang: 'de', | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Ik denk dat deze stories opgedeeld moeten worden in 2 varianten:
- parent heeft een bepaalde taal (
lang="ar" dir="rtl"bijvoorbeeld), de code heeft een andere taal (lang="en") - code heeft een specifieke taal (bijvoorbeeld:
lang="en"), de story houdt geen rekening met een parent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #248