Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter options #50

Open
trying-to-decipher opened this issue Sep 19, 2018 · 3 comments
Open

filter options #50

trying-to-decipher opened this issue Sep 19, 2018 · 3 comments

Comments

@trying-to-decipher
Copy link

Would it be possible to create more visual options for the filter settings? Could there be a filter that acts as a search, for lets say the category year, such that I could type in 1994 and only posts categorized with that year appears in my grid?

@nk-o
Copy link
Collaborator

nk-o commented Sep 19, 2018

In plans 1 additional style for the filter that looks like dropdown.

To add search you will need to customize default templates for this filter. I don't think search will be added in the near future.

@carson-nr
Copy link

carson-nr commented Aug 7, 2019

Had an issue when visitors would use the back button to return to a filtered results page.

Some devices cached the page in its original state, and others cached the page in it's filtered state.
(Behavior was very inconsistent. the same browser would behave differently on different devices)

I was able to conclude this was due to the way the AJAX call is used to reload the page, so that the query parameters are hidden from the address bar.

commenting out the e.preventDefault() in assets/js/script.js allowed the page to transition naturally, using the query parameters. This allowed each filtered result to be cached as a page individually.

I've started looking into submitting a pull request to allow this to be a toggle setting, but was not sure exactly how to best implement this to match your style.

@nk-o
Copy link
Collaborator

nk-o commented Aug 8, 2019

@Carson2006 which devices are you talking about? The latest Android Chrome and iOs Safari don't "cache" the page state.

Since we use AJAX loading without state change, the browser doesn't know the page was changed (actually it wasn't changed, we only loaded the new content for the Portfolio shortcode).

If you want to change address state once AJAX loaded, first we need to create better permalinks for the filters and sort. #7. But currently, I don't know how to make it possible.

p.s. Better to create a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants