From 6fe8dde1b6649b2a12d46a868da31aad69b8012c Mon Sep 17 00:00:00 2001 From: Jinzhe Zeng Date: Mon, 14 Oct 2024 20:54:22 -0400 Subject: [PATCH] ci: pin ubuntu to 22.04 (#4213) It seems that GitHub starts to point ubuntu-latest to ubuntu-24.04 (xref: https://github.com/actions/runner-images/issues/10636), which brings some breaking changes. For example, cuda 11.8 doesn't support the default compiler in ubuntu-24.04. ## Summary by CodeRabbit - **New Features** - Updated build, test, and analysis workflows to run on Ubuntu 22.04, enhancing compatibility and performance for C++ projects. - **Bug Fixes** - Corrected indentation in the permissions section of the CodeQL workflow. - **Chores** - Adjusted timeout settings for the CodeQL analysis job based on the programming language. --- .github/workflows/build_cc.yml | 2 +- .github/workflows/codeql.yml | 2 +- .github/workflows/test_cc.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build_cc.yml b/.github/workflows/build_cc.yml index 775b88cfd3..a1ac032891 100644 --- a/.github/workflows/build_cc.yml +++ b/.github/workflows/build_cc.yml @@ -11,7 +11,7 @@ name: Build C++ jobs: buildcc: name: Build C++ - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 strategy: matrix: include: diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index c912ece8d5..583e7785d9 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -13,7 +13,7 @@ concurrency: jobs: analyze: name: Analyze - runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }} + runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-22.04' }} timeout-minutes: ${{ (matrix.language == 'swift' && 120) || 360 }} permissions: actions: read diff --git a/.github/workflows/test_cc.yml b/.github/workflows/test_cc.yml index ebbfc4d960..768590980f 100644 --- a/.github/workflows/test_cc.yml +++ b/.github/workflows/test_cc.yml @@ -11,7 +11,7 @@ name: Test C++ jobs: testcc: name: Test C++ - runs-on: ubuntu-latest + runs-on: ubuntu-22.04 strategy: matrix: check_memleak: [true, false]