Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.11 module support #13

Open
benpye opened this issue Oct 19, 2018 · 4 comments
Open

Go 1.11 module support #13

benpye opened this issue Oct 19, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@benpye
Copy link

benpye commented Oct 19, 2018

Any ideas about support Go 1.11's modules, several projects already seem to have adopted the new way of doing things, for example https://github.com/miniflux/miniflux and it'd be nice to have a good way to build these under NixOS.

@qknight
Copy link
Member

qknight commented Oct 20, 2018

@benpye no plans yet. if you get funding, we might implment nix support.

at the meantime we use dep for our projects and sometimes i use it to 'easily' generate the deps.nix for projects which don't do dep.

@benpye
Copy link
Author

benpye commented Oct 20, 2018

I decided to look into this a little bit, it seems Go defined a proxy protocol which can be used to provide the files, see: https://golang.org/cmd/go/#hdr-Module_proxy_protocol . This doesn't really make clear if there is any good way of parsing your go.mod or maybe go.sum and actually fetching the required files.

@qknight
Copy link
Member

qknight commented Oct 21, 2018

a good way would be to implement a patch to the go programming language where we could generate Gopkgs.lock like file from which we can generate a deps.nix file which would feed into the https://golang.org/cmd/go/#hdr-Module_proxy_protocol you listed.

the most important thing would be to use the dependency resolver which would also be used when using go get or whatever go expects so the dependencies end up beeing the same.

sounds like an interesting project, i wish someone would find it, would love to implement that.

@qknight qknight closed this as completed Oct 21, 2018
@CrushedPixel
Copy link
Collaborator

CrushedPixel commented Oct 21, 2018

The best way to make people aware that this is needed for dep2nix is keeping this issue open.

IMO, a "patch for the go programming language", as you put it, does not sound like that right approach. If anything, we could re-use the dependency resolver used by go get and build our own tool on top of that, similar to how we use dep as a dependency library for dep2nix.

@CrushedPixel CrushedPixel reopened this Oct 21, 2018
@CrushedPixel CrushedPixel added the enhancement New feature or request label Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants