Configure build system for blinker >= 1.6.3 #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0b0
reviewed
Oct 11, 2023
overrides/build-systems.json
Outdated
| }, | ||
| { | ||
| "buildSystem": "flit-core", | ||
| "from": "1.6.2" |
There was a problem hiding this comment.
This looks like the opposite error: from is inclusive, so this should be "1.6.3". By the way, it's generally better to just update a PR (even rewriting history) than creating a new PR with the same purpose.
For more info on why this seeming inconsistency is preferred, see for example Always use [closed, open) intervals.
There was a problem hiding this comment.
👍 Wasn't paying enough attention. Fixed now.
it's generally better to just update a PR (even rewriting history) than creating a new PR with the same purpose.
I'm not sure how I can update some else's PR? Or do you mean rebasing this PR on theirs?
There was a problem hiding this comment.
Oh whoops, I assumed you were the same author!
apeschar
force-pushed
the
blinker-build
branch
from
21cbf51 to
6c57768
Compare
cpcloud
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1341, but with tests, and the exclusive
untilset properly.I didn't notice the other PR until I nearly finished this.