Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+doom-dashboard-init-h (void-function doom-modeline-set-project-modeline) #325

Closed
souxd opened this issue Nov 1, 2022 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@souxd
Copy link

souxd commented Nov 1, 2022

Using emacs 28.2 NativeComp

I had to override doom-modeline to a different revision because the current nix-doom-emacs eglot pin would break without it doomemacs/doomemacs@aa40daf. But this change came at the cost of introducing a new modeline error on init:
`Error during redisplay: (doom-init-ui-h #<frame scratch – Doom Emacs 0x30b1938>) signaled (doom-hook-error doom-init-ui-hook +doom-dashboard-init-h (void-function doom-modeline-set-project-modeline))

flake.lock
https://pastebin.com/Uw40CtdP

@souxd souxd added the bug Something isn't working label Nov 1, 2022
@thiagokokada
Copy link

thiagokokada commented Nov 1, 2022

Using emacs 28.2 NativeComp

I had to override doom-modeline to a different revision because the current nix-doom-emacs eglot pin would break without it doomemacs/doomemacs@aa40daf. But this change came at the cost of introducing a new modeline error on init: `Error during redisplay: (doom-init-ui-h #<frame scratch – Doom Emacs 0x30b1938>) signaled (doom-hook-error doom-init-ui-hook +doom-dashboard-init-h (void-function doom-modeline-set-project-modeline))

flake.lock https://pastebin.com/Uw40CtdP

You shouldn't override the doom-modeline, it is there for one reason: #309. Until #316 is finished, this will be the situation unfortunately.

For now, my recommendation would be to try to pin eglot to a early version.

@thiagokokada
Copy link

thiagokokada commented Nov 1, 2022

I will try to remove the current doom-modeline pin and add this as an workaround: #309 (comment).

However not sure if this will work well.

If you want a recommendation from me, I particularly use (modeline +light) instead that is faster and also much less bloated, and it basically avoids most of those issues.

@thiagokokada
Copy link

@souxd Can you try #326 to see if it fixes your issue?

@souxd
Copy link
Author

souxd commented Nov 1, 2022

Oh yes it does fix my issue! Thank you mr. Kokada!

Closing this since my issue was fixed.

@souxd souxd closed this as completed Nov 1, 2022
@thiagokokada thiagokokada reopened this Nov 1, 2022
@thiagokokada
Copy link

thiagokokada commented Nov 1, 2022

Let keep this open until #326 is merged.

@thiagokokada
Copy link

#326 is merged, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants