-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.0 Notes #5
Comments
Here is a possible alternative setup After toying with it for a bit (and considering other enhancements) there are some tradeoffs to consider, so I wouldn't just jump at merging this in.
Anywho food for thought really. I'm noticing that the rotationOffset is not working the same way as before I tried to make the main item in the bottom left corner but different #'s of items reposition this differently. My other bug/note is that I'm trying to make items fade out and in upon scaling/hovering (if you refer to my demo) and am having a hard time coordinating this with the scale animation. Try rotating and then mouseout mid-animation |
Re: double spaced code -- I decided that the extra bytes were ok in an effort to provide more comments in the code while not cluttering it up. It's a new style I'm trying out - I appreciate the feedback, though. Re: merging forks - to be honest I haven't actually gone through with it before. That said, I didn't make an effort to merge the fix which was my bad! I think what you've updated is great, and frankly what I should have done in terms of properly implementing animation control to the end user. Re: animation - I can't believe that I used "swing" as the default animation easing type, and completely agree it is too jarring. I was playing around with them and rushed the release out -- I agree linear is the best. Onto the notes: Linear - default for sure. I don't think it's worth hard coding it in -- some effects could be used (or so I think, FYI i'm not a designer though I do enjoy design). I like the breakout of the animation properties. It makes sense. W/ regards to the event after an animation occurs, params may not be passed in - but that is easy to rectify. Do you not see the value in that method? If after an animation you want to perform some operation? I've found it useful in a couple of demos. With regards to the Radmenu in general - I'm going to take a step back and try and see how this is easily implemented, because while I think that the power of the plugin is great, I'm not so sure how comfortable people are implementing it. I find myself needing to play with angles, transforms and programatically doing things more so than I feel like I should. I'm not sure how thats received. I've tried my best to make it accessible and documented, though. About the physics enhancements - I would love to do this. I have been wanting to turn this project into a wonderwheel - an interface thats becoming more popular particularly in discovery (i.e. music - discovr ipad app). If you have any tips I'de welcome them - and will try to get into this soon. Thanks for taking the time to work through the enhancements. I absolutely value feedback and simply want this interface to be a fun and exciting interface w/out flash. I appreciate the feedback and look forward to the next update. |
Re: easing - If you think about it, every animation happens for 1 individual rotation. Any easing that isn't constant will cause fluctuations while the wheel rotates (such as stopping and starting or speeding up and slowing down). I can't really think of any easing in which this would look good. Re: callback params - I actually wasn't able to visualize a good use since when I had 20 items and scaled the entire wheel, it executed the callback 20 times, which seemed strange (even if I DO make changes to individual items). I went back and looked at all of your demos, and the only callback you use is the onSelect event, not onScale or onRotate. Also, the developer still has access to Re: in general - Uh.... huh? I'm not exactly sure I follow what you're referring to specifically? I have found it fairly easy to implement the plugin (aside from a small bug or two). If you're talking about extending the plugin, I actually didn't look at the physic calculations too much. Can you be more specific what problems you were having or was trying to build? Re: enhancements - Would be interesting to be able to control the entire rotation animation queue together (aka having rotation slow down as it reaches the end, etc). Also, simply adding a mousewheel example (such as my implementation) I think would be nifty. |
Check this code out (I haven't tested it personally yet): (Assuming the beginning co-ordinates of the box to be 200px to the right and 250px from the top and radius of the circle to be 200px, i.e. centre is at 400px to the right and 250px from the top. If you want different figures, change the values accordingly, it is very easy.). The HTML and CSS is not given..
|
.animate( properties, options )
. This way you don't obfuscate control from the user. I'll add a commit with the suggested changes in a minute. Nice to see you notice other people's contributions :)The text was updated successfully, but these errors were encountered: