Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Amend some error types #63

Closed
wants to merge 1 commit into from

Conversation

oesteban
Copy link
Collaborator

Trying to normalize a little between TypeErrors and ValueErrors.

@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     FIX: Amend some error types

Powered by Pull Assistant. Last update ad0f004 ... ad0f004. Read the comment docs.

@oesteban oesteban requested a review from mgxd February 25, 2020 23:17
@codecov-io
Copy link

Codecov Report

Merging #63 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   98.52%   98.42%   -0.11%     
==========================================
  Files          11       11              
  Lines         951      951              
  Branches      130      130              
==========================================
- Hits          937      936       -1     
  Misses          7        7              
- Partials        7        8       +1
Flag Coverage Δ
#unittests 98.42% <100%> (-0.11%) ⬇️
Impacted Files Coverage Δ
nitransforms/linear.py 96.05% <100%> (ø) ⬆️
nitransforms/nonlinear.py 100% <100%> (ø) ⬆️
nitransforms/base.py 98.85% <0%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 955cd38...ad0f004. Read the comment docs.

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see we include a custom TransformError - should that be raised instead?

@oesteban
Copy link
Collaborator Author

Let's check on all error types when merging into nibabel (#110).

@oesteban oesteban closed this Feb 17, 2022
@oesteban oesteban deleted the enh/transforms-map-2 branch February 17, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants