Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio buttons should not be deselectable #76

Open
jamesrussell216 opened this issue Jul 19, 2024 · 6 comments
Open

Radio buttons should not be deselectable #76

jamesrussell216 opened this issue Jul 19, 2024 · 6 comments

Comments

@jamesrussell216
Copy link

jamesrussell216 commented Jul 19, 2024

In the Acquisition window, you can click on a selected Mode radio button and have no select radio options!

image

@cmeyer cmeyer changed the title Acquisition Panel - Can deselect the radial options! Radio buttons should not be deselectable Jul 19, 2024
@cmeyer
Copy link
Collaborator

cmeyer commented Jul 19, 2024

This is the result of this change nion-software/nionui-tool@67c5dec. I am reviewing why that change was needed.

@cmeyer cmeyer transferred this issue from nion-software/nionswift Jul 19, 2024
@cmeyer cmeyer self-assigned this Jul 19, 2024
@cmeyer
Copy link
Collaborator

cmeyer commented Jul 19, 2024

This is fixed nion-software/nionui-tool@419509e and f378ed7

However, I am not 100% confident about the fix - I had disabled a setting for "autoExclusive" (auto disables other buttons belonging to a common parent) on the Qt radio buttons in May 2021, but I couldn't find any case where it fails now without "autoExclusive" disabled. So I re-enabled it and that fixes this particular issue. As a fallback, I included a way to set the "autoExclusive" setting from Python in the future if needed.

General point is that Declarative should auto-create a radio group to fully resolve this issue. The problem with doing that is where to store the button group... I'll leave that as an exercise for another day.

Watch for other radio button issues now that I've re-enabled "autoExclusive". Possible issue would be wrong item selected even though the correct radio button is enabled.

@cmeyer cmeyer closed this as completed Jul 19, 2024
@jamesrussell216
Copy link
Author

Sorry @cmeyer but still seems to be possible unless I'm missing something...

image

@cmeyer
Copy link
Collaborator

cmeyer commented Jul 22, 2024

To test this, you either need to run Swift using PyQtProxy (latest code) or using a newly built nionui-tool. Are you still seeing the error in one/both of those situations? More details on launching with nionui-tool here.

@jamesrussell216
Copy link
Author

@cmeyer I thought so but @KRLango then found...

https://github.com/nion-software/nionui-tool/actions/runs/10010833174

Is that going to be why?!

@cmeyer
Copy link
Collaborator

cmeyer commented Jul 23, 2024

Did you run the Windows version from that link? The linux and macos builds are failing, but the Windows build looks successful. (I'm working on those builds separately)

@cmeyer cmeyer removed their assignment Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants