Display values can be sent to DisplayCanvasItem inconsistently

[cmeyer]

This is an internal issue and can result in inconsistent calibration data between the display canvas item (specifically the ImageCanvasItem) and the display data, resulting in incorrect calibration data.

Particularly, in upcoming calibration style improvements, the user changing calibration style results in a temporary state where the display canvas item has data that has the wrong number of dimension calibrations.

This is not a visible bug in the current version (which does not need the dimension calibrations in the display), but prevents upcoming calibration improvements.

The solution is to pass the combination of display-values and calibration info at the same time rather than split into two methods (update_display_values and update_display_properties_and_layers).

Tasks

Preview Give feedback

1. Cursor info becomes disconnected after crop followed by delete crop

[cmeyer]

commit 93fbc09
Date: Tue Mar 12 12:19:06 2024 -0700

Consolidate sending display data delta changes; also work around missing-reference-during-loading issue and display layer.

commit c402f3b
Date: Mon Mar 11 19:13:57 2024 -0700

Remove unused classes.

commit d4184c4
Date: Mon Mar 11 16:50:23 2024 -0700

Move all display data logic to display item. Track display data channels directly in tracker class.

commit 1312c73
Date: Mon Mar 11 16:23:21 2024 -0700

Add a DisplayDataDelta stream to DisplayItemDimensionsMetadata.

commit 0ad54f7
Date: Mon Mar 11 15:22:02 2024 -0700

Add tracking of graphics, graphics selection, display layers, display property to DisplayItemDimensionsMetadata.

commit 53dee22
Date: Sun Mar 10 11:51:02 2024 -0700

Move DisplayData class to DisplayItem file.

commit bbec068
Date: Thu Mar 7 13:28:38 2024 -0800

Consolidate DisplayCalibrationInfo and DisplayItemDimensionsMetadata and handling in DisplayPanel.

commit 4700225
Date: Thu Mar 7 11:24:11 2024 -0800

Consolidate display item update to a single 'update_display_data_delta' call.

commit 05d01d8
Date: Thu Mar 7 11:09:19 2024 -0800

Introduce DisplayDataDelta for communicating DisplayData changes to the displays.

commit 91f26fd
Date: Thu Mar 7 08:20:49 2024 -0800

Introduce DisplayData to help track changes in DisplayTracker.

commit c886428
Date: Tue Feb 13 19:28:56 2024 -0800

Change display data items model to track display values instead. Renaming and other refactoring too.

commit f3d1e9e
Date: Tue Feb 13 10:08:08 2024 -0800

Introduce display data shape calculator class to consolidate calculation of display data dimension indexes.

commit 5653ba2
Date: Mon Feb 12 18:01:41 2024 -0800

Consolidate more coordinate system code into DisplayItemCoordinates.

commit 8c038fc
Date: Mon Feb 12 13:09:28 2024 -0800

Introduce data items model and coordinates model for display item.

This is part of a change to make the depenendencies between various display item properties
explicit and ultimately simplify how display canvas items are updated.

commit f16eff8
Date: Sat Mar 2 09:17:40 2024 -0800

Eliminate direct updating when updating image position on image canvas item.

commit 32f1244
Date: Sat Mar 2 08:32:23 2024 -0800

Directly update/refresh_layout (now thread-safe) instead of queuing to UI thread.

commit 0628d07
Date: Fri Mar 1 12:28:04 2024 -0800

Ensure line plot update method is thread safe.

commit 56f41d3
Date: Thu Feb 29 10:52:30 2024 -0800

Image canvas display refactoring.