Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WHAT A STRANGE UPDATE #313

Closed
summonerriftofficial opened this issue Jul 11, 2020 · 4 comments
Closed

WHAT A STRANGE UPDATE #313

summonerriftofficial opened this issue Jul 11, 2020 · 4 comments
Labels
5.0.0-breaking-change

Comments

@summonerriftofficial
Copy link

when you are planning to update the library make sure to include the old features not remove them for no reason or just don't do any changes cuz everything was working perfectly before

I'm so sad that I have to use the old version with a branch link.
@skaunited
Copy link

I share exactly the same feeling with @summonerriftofficial,
I don't know for any reason you've changed the 'NVActivityIndicatorPresenter'. and the 'ActivityData' names but at least keep up to date from the Readme

@ninjaprox
Copy link
Owner

ninjaprox commented Jul 13, 2020 •
edited
Loading

Sorry for all inconvenience. There is a release note for version 5.0.0. Although NVActivityIndicatorPresenter is marked as deprecated, it's still usable, just bare with warnings. I'll update README for better communication of this breaking change.

@preetamjadakar
Copy link

Really surprised to see this change. the least expectation is not to plan deprecation without proper alternatives.

@ninjaprox
Copy link
Owner

Close in favor of #315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5.0.0-breaking-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@preetamjadakar @ninjaprox @skaunited @summonerriftofficial