Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and warn on errors caused by Brave shields #425

Open
danimoh opened this issue Aug 11, 2020 · 0 comments
Open

Detect and warn on errors caused by Brave shields #425

danimoh opened this issue Aug 11, 2020 · 0 comments

Comments

@danimoh
Copy link
Member

danimoh commented Aug 11, 2020

For example using https://nimiqgiftcards.com/ with enabled brave shields (more specifically the "Cross-site cookies blocked" setting) causes an "Invalid request" error in the Hub on redirect.
This problem seems to occur only for cross-origin requests.
The actual cause has not been investigated yet, but likely access to the session storage or another storage is blocked.
If the problem is within the scope of the rpc lib, the detection should happen there, but appropriate error handling would need to be implemented in the hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant