Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#286] Fix: Terraform plan can't be applied because of VPC endpoint misconfiguration #304

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[#286] Fix: Terraform plan can't be applied because of VPC endpoint misconfiguration #304

wants to merge 1 commit into from
+72 −7

Conversation

Nihisil
Copy link
Contributor

@Nihisil Nihisil commented Aug 29, 2024

What happened 👀

  • Route ECS - S3, ECS - ECR, and ECS - CloudWatch traffic through a private network instead of the internet to save money (public traffic costs money, private traffic does not).

Previously, we added it to the template, but it did not work. Now it is working.

Proof Of Work 📹

Before the fix we weren't able to apply tf plan generated from our code:

image

After the fix TF plan can be applied without error:

image

@Nihisil Nihisil added the type : bug Something isn't working label Aug 29, 2024
@Nihisil Nihisil added this to the 2.4.0 milestone Aug 29, 2024
@Nihisil Nihisil self-assigned this Aug 29, 2024
nvminhtue
nvminhtue approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@nvminhtue nvminhtue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

malparty
malparty approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@malparty malparty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Need to pull these changes in my projects too now 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malparty malparty malparty approved these changes

@sanG-github sanG-github sanG-github approved these changes

@nvminhtue nvminhtue nvminhtue approved these changes

@andyduong1920 andyduong1920 Awaiting requested review from andyduong1920 andyduong1920 is a code owner

@bterone bterone Awaiting requested review from bterone bterone is a code owner

@byhbt byhbt Awaiting requested review from byhbt byhbt is a code owner

@hoangmirs hoangmirs Awaiting requested review from hoangmirs hoangmirs is a code owner

@liamstevens111 liamstevens111 Awaiting requested review from liamstevens111 liamstevens111 is a code owner

@longnd longnd Awaiting requested review from longnd longnd is a code owner

Assignees

@Nihisil Nihisil

Labels
type : bug Something isn't working
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Fix: Terraform plan can't be applied because of VPC endpoint misconfiguration
4 participants
@Nihisil @nvminhtue @sanG-github @malparty