Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Split tests into several files #66

Open
malparty opened this issue Jul 23, 2021 · 1 comment
Open

[RFC] Split tests into several files #66

malparty opened this issue Jul 23, 2021 · 1 comment

Comments

@malparty
Copy link
Member

malparty commented Jul 23, 2021

Why

The current cmd/create_test.go file is becoming very long (and will become longer!).

Impacts:

  • Some rebase generate conflicts headache (due to the code high resemblance).
  • Makes maintaining tests harder

Who Benefits?

Developers for

  • maintenance tasks
  • new features

Poll

3 options:

  1. Keep as current (1 single big file `create_test.go)
  2. Add 1 *_test.go file per add-ons/variant. This would go against our Go conventions so let's open a discussion here.
  3. Keep create_test.go for core tests and have it to import (and run) other sub-files (1 per add-ons/variant).



@gutakk
Copy link
Contributor

gutakk commented Jul 23, 2021

I voted for 2 because this case is worth breaking the golang convention as it is easier to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants