Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gh315] Support Phoenix 1.7.x #318

Draft
wants to merge 51 commits into
base: develop
Choose a base branch
from
Draft

[gh315] Support Phoenix 1.7.x #318

wants to merge 51 commits into from
+746 −900

Commits on Mar 10, 2023

  1. [gh315] Upgrade the template dependencies and Phoenix to 1.7.0

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    0abae0b View commit details
    Browse the repository at this point in the history

  2. [gh315] Remove Phoenix view

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    f4c0e85 View commit details
    Browse the repository at this point in the history

  3. [gh315] Upgrade to Phoenix 1.7.1

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    f2da7a0 View commit details
    Browse the repository at this point in the history

  4. [gh315] Upgrade the docs

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    29121fa View commit details
    Browse the repository at this point in the history

  5. [gh315] Do not need --no-live when the --no-html is given

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    ec3d4b8 View commit details
    Browse the repository at this point in the history

  6. [gh315] Update - 1

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    8285a95 View commit details
    Browse the repository at this point in the history

  7. [gh315] Update - 2

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e0f71d3 View commit details
    Browse the repository at this point in the history

  8. [gh315] Format

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    898d053 View commit details
    Browse the repository at this point in the history

  9. [gh315] Format

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e5c6bac View commit details
    Browse the repository at this point in the history

  10. [gh315] Fix the gettext

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    8fafd23 View commit details
    Browse the repository at this point in the history

  11. [gh315] Fix linting

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d711e97 View commit details
    Browse the repository at this point in the history

  12. [gh315] Fix the wallaby with httppoison

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    993f8bf View commit details
    Browse the repository at this point in the history

  13. [gh315] Fix format

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    21f9553 View commit details
    Browse the repository at this point in the history

  14. [gh315] Fix wallaby

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e01a3a9 View commit details
    Browse the repository at this point in the history

  15. [gh315] Fix wallaby

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    ba9d749 View commit details
    Browse the repository at this point in the history

  16. [gh315] Disable SVG

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    a7067d6 View commit details
    Browse the repository at this point in the history

  17. [gh315] Fix the CoreComponents

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    cfee357 View commit details
    Browse the repository at this point in the history

  18. [gh315] Fix the CoreComponents

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d58e92a View commit details
    Browse the repository at this point in the history

  19. [gh315] Fix the CoreComponents

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    9963795 View commit details
    Browse the repository at this point in the history

  20. [gh315] Disable the EmptyBodyParamsPlugTest

    @andyduong1920
    andyduong1920 committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    33e0727 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. [gh315] Remove the httppoison as Wallaby released the new version

    @andyduong1920
    andyduong1920 committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    cbf2e4f View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Remove the CoreComponent

    @andyduong1920
    andyduong1920 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    20a369e View commit details
    Browse the repository at this point in the history

  2. [gh315] Fix the credo on the web entry point

    @andyduong1920
    andyduong1920 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d91d395 View commit details
    Browse the repository at this point in the history

  3. [gh315] Fix the credo and the feature test

    @andyduong1920
    andyduong1920 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d8fd6aa View commit details
    Browse the repository at this point in the history

  4. [gh315] Fix the credo and the feature test

    @andyduong1920
    andyduong1920 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    766e541 View commit details
    Browse the repository at this point in the history

  5. [gh315] Skip test on the core_components

    @andyduong1920
    andyduong1920 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    9890876 View commit details
    Browse the repository at this point in the history

  6. [gh315] Fix credo helper

    @andyduong1920
    andyduong1920 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ad453cc View commit details
    Browse the repository at this point in the history

  7. [gh315] Fix credo helper

    @andyduong1920
    andyduong1920 committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    87b59ce View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Initial

    @liamstevens111
    liamstevens111 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    0b73dc2 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate code introduced

    @liamstevens111
    liamstevens111 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    f8225ad View commit details
    Browse the repository at this point in the history

  3. Change IconHelper tests to pipe |> syntax

    @liamstevens111
    liamstevens111 committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    47bdea3 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #320 from nimblehq/feature/incorporate-verified-ro… 

    …utes

Change use of Router.Helpers to VerifiedRoutes
    @andyduong1920
    andyduong1920 authored Mar 16, 2023
    Configuration menu
    Copy the full SHA
    25fd192 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Initial conversion from ErrorView to ErrorJSON view

    @liamstevens111
    liamstevens111 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    614792e View commit details
    Browse the repository at this point in the history

  2. Change to match pre-existing custom error output and tests

    @liamstevens111
    liamstevens111 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    a9d9325 View commit details
    Browse the repository at this point in the history

  3. Add Plug.Conn.Status alias

    @liamstevens111
    liamstevens111 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    9baa1c5 View commit details
    Browse the repository at this point in the history

  4. Add test for non-exisitant error code

    @liamstevens111
    liamstevens111 committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    4a0c259 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2023

  1. Include changeset error output and tests

    @liamstevens111
    liamstevens111 committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    3e26ff0 View commit details
    Browse the repository at this point in the history

  2. Disable singlemodulefile CompassCredoCheck for test file

    @liamstevens111
    liamstevens111 committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    b496595 View commit details
    Browse the repository at this point in the history

  3. Add test for ensuring file exists for ErrorJSON in template

    @liamstevens111
    liamstevens111 committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    d9a3c6c View commit details
    Browse the repository at this point in the history

  4. Fix webmodule name for Gettext

    @liamstevens111
    liamstevens111 committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    116856a View commit details
    Browse the repository at this point in the history

  5. Add ErrorJSON to multiple module disable rule

    @liamstevens111
    liamstevens111 committed Mar 19, 2023
    Configuration menu
    Copy the full SHA
    2bd1e00 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Use translate_error/1 from CoreComponents instead of redefining

    @liamstevens111
    liamstevens111 committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    33b9e63 View commit details
    Browse the repository at this point in the history

  2. Change to use ErrorJSON in Fallback Controller and check_empty_body_p… 

    …arams_plug
    @liamstevens111
    liamstevens111 committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    c725541 View commit details
    Browse the repository at this point in the history

  3. Fix CoreComponent webmodule prefix for translate

    @liamstevens111
    liamstevens111 committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    4e7621b View commit details
    Browse the repository at this point in the history

  4. Fix CoreComponent import again

    @liamstevens111
    liamstevens111 committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2887ee6 View commit details
    Browse the repository at this point in the history

  5. Add back translate_errors as CoreComponents cant be found

    @liamstevens111
    liamstevens111 committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    31aea20 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Update ViewCase although it doesn't seem to be used

    @liamstevens111
    liamstevens111 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    8d6bb13 View commit details
    Browse the repository at this point in the history

  2. Update ViewCase although it doesn't seem to be used

    @liamstevens111
    liamstevens111 committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    d408554 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Remove TODO and RouteHelper from feature_case and view_case

    @liamstevens111
    liamstevens111 committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    334c0da View commit details
    Browse the repository at this point in the history

  2. Remove RouteHelper from tests

    @liamstevens111
    liamstevens111 committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    dece778 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #323 from nimblehq/feature/revisit-error-view 

    Convert from ErrorView to new ErrorJSON view
    @andyduong1920
    andyduong1920 authored Apr 4, 2023
    Configuration menu
    Copy the full SHA
    0fc9f5a View commit details
    Browse the repository at this point in the history