Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate the Twitter Jetpack Compose Rules Detekt plugin #541

Open
ryan-conway opened this issue Oct 11, 2023 · 0 comments · May be fixed by #556
Open

Integrate the Twitter Jetpack Compose Rules Detekt plugin #541

ryan-conway opened this issue Oct 11, 2023 · 0 comments · May be fixed by #556
Assignees
@ryan-conway
Labels
priority : normal type : chore
Milestone
3.31.0

Comments

@ryan-conway
Copy link
Collaborator

ryan-conway commented Oct 11, 2023 •
edited
Loading

Why

With the current Detekt configuration from the template, it doesn't adapt well to Composable UI components. There are several new set of rules for Jetpack Compose that you might need for your project.

We can integrate the Twitter Jetpack Compose Rules detekt plugin to keep on top of any changes to detekt rules and improve our Jetpack Compose code quality.

Who Benefits?

Developers

Acceptance Criteria

  • Add the compose-rules gradle plugin to template-compose
  • Update detekt-config.yml to activate the rules
@ryan-conway ryan-conway added this to the 3.26.0 milestone Oct 11, 2023
@ryan-conway ryan-conway self-assigned this Nov 3, 2023
ryan-conway added a commit that referenced this issue Nov 3, 2023
@ryan-conway
[#541] Update detekt rules for Jetpack Compose
429fa8f
ryan-conway added a commit that referenced this issue Nov 3, 2023
@ryan-conway
[#541] Handle unstable collections detekt warning
5662c4f
@ryan-conway ryan-conway linked a pull request Nov 3, 2023 that will close this issue
Open
@ryan-conway ryan-conway modified the milestones: 3.26.0, 3.27.0 Dec 1, 2023
ryan-conway added a commit that referenced this issue Dec 15, 2023
@ryan-conway
[#541] Update detekt rules for Jetpack Compose
be92fe1
ryan-conway added a commit that referenced this issue Dec 15, 2023
@ryan-conway
[#541] Handle unstable collections detekt warning
391946a
@ryan-conway ryan-conway modified the milestones: 3.27.0, 3.28.0 Dec 29, 2023
@ryan-conway ryan-conway modified the milestones: 3.28.0, 3.29.0 Apr 1, 2024
@ryan-conway ryan-conway modified the milestones: 3.29.0, 3.30.0 Aug 1, 2024
@ryan-conway ryan-conway modified the milestones: 3.30.0, 3.31.0 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryan-conway ryan-conway

Labels
priority : normal type : chore
Projects
None yet
Milestone
3.31.0
Development

Successfully merging a pull request may close this issue.

[#541] Integrate the Twitter Jetpack Compose Rules Detekt plugin nimblehq/android-templates
1 participant
@ryan-conway