Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - [#494] Replace danger-ruby with danger-kotlin #498

Closed
wants to merge 1 commit into from
Closed

WIP - [#494] Replace danger-ruby with danger-kotlin #498

wants to merge 1 commit into from
+21 −24

Conversation

chornerman
Copy link
Member

@chornerman chornerman commented Aug 3, 2023 •
edited
Loading

#494

What happened 👀

  • Replace danger-ruby with danger-kotlin on templates' GitHub Actions workflow
  • Replace danger-ruby with danger-kotlin on generated project's GitHub Actions workflow

Insight 📝

N/A

Proof Of Work 📹

Will update

@chornerman chornerman self-assigned this Aug 3, 2023
@chornerman chornerman changed the title [#494] Replace danger-ruby with danger-kotlin WIP - [#494] Replace danger-ruby with danger-kotlin Aug 3, 2023
@chornerman chornerman force-pushed the feature/#494-replace-danger-ruby-with-danger-kotlin branch from 0d690b3 to 2025322 Compare August 3, 2023 03:58
@chornerman chornerman temporarily deployed to template-compose August 3, 2023 03:58 — with GitHub Actions Inactive
@chornerman chornerman force-pushed the feature/#494-replace-danger-ruby-with-danger-kotlin branch from 2025322 to 18b0e80 Compare August 3, 2023 04:17
@chornerman chornerman temporarily deployed to template-compose August 3, 2023 04:17 — with GitHub Actions Inactive
@chornerman chornerman force-pushed the feature/#494-replace-danger-ruby-with-danger-kotlin branch from 18b0e80 to b971e0e Compare August 3, 2023 04:57
@chornerman chornerman temporarily deployed to template-compose August 3, 2023 04:57 — with GitHub Actions Inactive
@chornerman chornerman force-pushed the feature/#494-replace-danger-ruby-with-danger-kotlin branch from b971e0e to 005cbed Compare August 3, 2023 05:55
@chornerman chornerman temporarily deployed to template-compose August 3, 2023 05:55 — with GitHub Actions Inactive
@chornerman chornerman temporarily deployed to template-compose August 3, 2023 05:55 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Warnings
⚠️ PR is classed as Work in Progress

Generated by 🚫 Danger Kotlin against 005cbed

@luongvo luongvo linked an issue Aug 23, 2023 that may be closed by this pull request
Replace danger-ruby with danger-kotlin #494
Open
@chornerman
Copy link
Member Author

Closing for now due to unable to migrate Shroud to danger-kotlin

@chornerman chornerman closed this Oct 27, 2023
@luongvo luongvo mentioned this pull request May 28, 2024
Open
thawzintoe-ptut added a commit that referenced this pull request Jun 4, 2024
@thawzintoe-ptut
[#498] Added JDK setup in github action
8c6984f
thawzintoe-ptut added a commit that referenced this pull request Jun 26, 2024
@thawzintoe-ptut
[#498] Added JDK setup in github action
2a358de
thawzintoe-ptut added a commit that referenced this pull request Jun 26, 2024
@thawzintoe-ptut
[#493] Create New files for Danger integration in template android
003bb3b 
[#498] Added JDK setup in github action

[#493] Update code according to PR comment for template_review_pull_request.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AVI5HEK AVI5HEK Awaiting requested review from AVI5HEK AVI5HEK will be requested when the pull request is marked ready for review AVI5HEK is a code owner

@eeeeaa eeeeaa Awaiting requested review from eeeeaa eeeeaa will be requested when the pull request is marked ready for review eeeeaa is a code owner

@hoangnguyen92dn hoangnguyen92dn Awaiting requested review from hoangnguyen92dn hoangnguyen92dn will be requested when the pull request is marked ready for review hoangnguyen92dn is a code owner

@Johnsonmaung Johnsonmaung Awaiting requested review from Johnsonmaung Johnsonmaung will be requested when the pull request is marked ready for review Johnsonmaung is a code owner

@kaungkhantsoe kaungkhantsoe Awaiting requested review from kaungkhantsoe kaungkhantsoe will be requested when the pull request is marked ready for review kaungkhantsoe is a code owner

@luongvo luongvo Awaiting requested review from luongvo luongvo will be requested when the pull request is marked ready for review luongvo is a code owner

@manh-t manh-t Awaiting requested review from manh-t manh-t will be requested when the pull request is marked ready for review manh-t is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble will be requested when the pull request is marked ready for review minhnimble is a code owner

@RkNaing RkNaing Awaiting requested review from RkNaing RkNaing will be requested when the pull request is marked ready for review RkNaing is a code owner

@ryan-conway ryan-conway Awaiting requested review from ryan-conway ryan-conway will be requested when the pull request is marked ready for review ryan-conway is a code owner

@sleepylee sleepylee Awaiting requested review from sleepylee sleepylee will be requested when the pull request is marked ready for review sleepylee is a code owner

@thawzintoe-ptut thawzintoe-ptut Awaiting requested review from thawzintoe-ptut thawzintoe-ptut will be requested when the pull request is marked ready for review thawzintoe-ptut is a code owner

@toby-thanathip toby-thanathip Awaiting requested review from toby-thanathip toby-thanathip will be requested when the pull request is marked ready for review toby-thanathip is a code owner

@win-than-htike win-than-htike Awaiting requested review from win-than-htike win-than-htike will be requested when the pull request is marked ready for review win-than-htike is a code owner

Assignees

@chornerman chornerman

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace danger-ruby with danger-kotlin
1 participant
@chornerman