Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Danger to the generated project #493

Open
luongvo opened this issue Jul 21, 2023 · 0 comments · May be fixed by #579
Open

Integrate Danger to the generated project #493

luongvo opened this issue Jul 21, 2023 · 0 comments · May be fixed by #579
Assignees
@thawzintoe-ptut
Labels
priority : normal type : feature
Milestone
3.31.0

Comments

@luongvo
Copy link
Member

luongvo commented Jul 21, 2023

Why

The Danger has been integrated into the root template. However, it has not been integrated into the generated project (no Dangerfile), so we have to manually add Danger with initializing the new project (sample case).

Who Benefits?

Developers
@luongvo luongvo added this to the 3.23.0 milestone Jul 21, 2023
@ryan-conway ryan-conway self-assigned this Aug 2, 2023
@ryan-conway ryan-conway modified the milestones: 3.23.0, 3.24.0 Aug 30, 2023
@ryan-conway ryan-conway removed their assignment Aug 30, 2023
@ryan-conway ryan-conway modified the milestones: 3.24.0, 3.25.0, 3.26.0 Aug 30, 2023
@ryan-conway ryan-conway modified the milestones: 3.26.0, 3.27.0 Oct 26, 2023
@ryan-conway ryan-conway modified the milestones: 3.27.0, 3.28.0 Dec 1, 2023
@ryan-conway ryan-conway modified the milestones: 3.28.0, 3.29.0 Dec 29, 2023
@thawzintoe-ptut thawzintoe-ptut self-assigned this May 28, 2024
@ryan-conway ryan-conway modified the milestones: 3.29.0, 3.30.0 May 28, 2024
thawzintoe-ptut added a commit that referenced this issue Jun 4, 2024
@thawzintoe-ptut
[#493] Create New files for Danger integration in template android
b1176cb
@thawzintoe-ptut thawzintoe-ptut linked a pull request Jun 5, 2024 that will close this issue
Open
@thawzintoe-ptut thawzintoe-ptut linked a pull request Jun 5, 2024 that will close this issue
[#493] Integrate danger to the generated project #579
Open
thawzintoe-ptut added a commit that referenced this issue Jun 26, 2024
@thawzintoe-ptut
[#493] Create New files for Danger integration in template android
aa0b1d4
thawzintoe-ptut added a commit that referenced this issue Jun 26, 2024
@thawzintoe-ptut
[#493] Update code according to PR comment for template_review_pull_r…
db8238c 
…equest.yml
thawzintoe-ptut added a commit that referenced this issue Jun 26, 2024
@thawzintoe-ptut
[#493] Create New files for Danger integration in template android
003bb3b 
[#498] Added JDK setup in github action

[#493] Update code according to PR comment for template_review_pull_request.yml
@ryan-conway ryan-conway modified the milestones: 3.30.0, 3.31.0 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thawzintoe-ptut thawzintoe-ptut

Labels
priority : normal type : feature
Projects
None yet
Milestone
3.31.0
Development

Successfully merging a pull request may close this issue.

[#493] Integrate danger to the generated project nimblehq/android-templates
3 participants
@luongvo @thawzintoe-ptut @ryan-conway