From 70d59b544f11cccf5e9a570e23f133b70a740a82 Mon Sep 17 00:00:00 2001
From: alaviss <leorize+oss@disroot.org>
Date: Tue, 2 Jul 2024 13:29:43 -0500
Subject: [PATCH] publisher: use actions/download-artifact directly (#1364)

## Summary
Instead of depending on a third-party actions to download built
artifacts, use GitHub's CLI to search for the wanted ID and first-party
actions to download the wanted artifacts.

## Details
* Replaced usage of  `dawidd6/action-download-artifact`  with
`actions/download-artifact` .

---------

Co-authored-by: zerbina <100542850+zerbina@users.noreply.github.com>
---
 .github/workflows/publisher.yml | 58 ++++++++++++++++++++-------------
 1 file changed, 35 insertions(+), 23 deletions(-)

diff --git a/.github/workflows/publisher.yml b/.github/workflows/publisher.yml
index ae4eb4b8884..f940fb7a183 100644
--- a/.github/workflows/publisher.yml
+++ b/.github/workflows/publisher.yml
@@ -28,47 +28,64 @@ jobs:
       # Publish action needs a checkout
       - uses: actions/checkout@v4
 
+      - name: Obtain latest successful run id
+        id: finder
+        run: |
+          run_id=$(gh run list \
+            -c "$COMMIT" \
+            -w "$WORKFLOW" \
+            -s "$CONCLUSION" \
+            --limit 1 \
+            --json databaseId \
+            --jq '.[].databaseId')
+          if [[ -z $run_id ]]; then
+            echo "::error::Could not find any CI run for commit $COMMIT"
+            exit 1
+          fi
+          echo "run_id=$run_id" >> "$GITHUB_OUTPUT"
+        env:
+          COMMIT: ${{ github.event.after }}
+          WORKFLOW: ci.yml
+          CONCLUSION: success
+          GH_TOKEN: ${{ github.token }}
+
       # Download the latest instance of artifacts from a build done previously
       - name: Download generated docs
-        uses: dawidd6/action-download-artifact@v6
+        uses: actions/download-artifact@v4
         with:
-          workflow: ci.yml
-          workflow_conclusion: success
-          commit: ${{ github.event.after }}
+          run-id: ${{ steps.finder.outputs.run_id }}
           # Keep up-to-date with ci.yml
           name: Generated docs
           path: doc/html
+          github-token: ${{ github.token }}
 
       - name: Download generated source archive
-        uses: dawidd6/action-download-artifact@v6
+        uses: actions/download-artifact@v4
         with:
-          workflow: ci.yml
-          workflow_conclusion: success
-          commit: ${{ github.event.after }}
+          run-id: ${{ steps.finder.outputs.run_id }}
           # Keep up-to-date with ci.yml
           name: source archive
           path: release-staging
+          github-token: ${{ github.token }}
 
       - name: Download generated release binaries
-        uses: dawidd6/action-download-artifact@v6
+        uses: actions/download-artifact@v4
         with:
-          workflow: ci.yml
-          workflow_conclusion: success
-          commit: ${{ github.event.after }}
+          run-id: ${{ steps.finder.outputs.run_id }}
           # Keep up-to-date with ci.yml
-          name: release binaries.*
-          name_is_regexp: true
+          pattern: release binaries *
+          merge-multiple: "true"
           path: release-staging
+          github-token: ${{ github.token }}
 
       - name: Download release manifest tool
-        uses: dawidd6/action-download-artifact@v6
+        uses: actions/download-artifact@v4
         with:
-          workflow: ci.yml
-          workflow_conclusion: success
-          commit: ${{ github.event.after }}
+          run-id: ${{ steps.finder.outputs.run_id }}
           # Keep up-to-date with ci.yml
           name: release manifest tool
           path: release-staging
+          github-token: ${{ github.token }}
 
       - name: Publish docs
         uses: JamesIves/github-pages-deploy-action@v4.6.1
@@ -79,11 +96,6 @@ jobs:
       - id: release-files
         name: Create release manifest
         run: |
-          # Move the release binaries to the current folder
-          for d in "release binaries "*; do
-            mv -v "$d"/* .
-          done
-
           # Github Artifacts strip executable permissions so it has to be set again
           chmod 755 release_manifest
           # Create a new release manifest