Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frame_id of the published filtered image #2

Open
sayali-purdue opened this issue Dec 15, 2020 · 0 comments
Open

frame_id of the published filtered image #2

sayali-purdue opened this issue Dec 15, 2020 · 0 comments

Comments

@sayali-purdue
Copy link

A filtered image is published at line 85 in soft_color_filter.cpp. During static code review, I found that frame_id field of this published image is not set. I would really appreciate if you could provide me a couple of details:

  1. what is the reference frame for the filtered image? Is it same as that of the raw image input?
  2. As a developer of this code, do you think this frame_id info can be useful to others, who would want to use the soft_color_filter node?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant