Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fits don's include central value #4

Open
lonbar opened this issue Dec 15, 2023 · 1 comment
Open

Fits don's include central value #4

lonbar opened this issue Dec 15, 2023 · 1 comment

Comments

@lonbar
Copy link
Collaborator

lonbar commented Dec 15, 2023

One thing I noticed is that the x_values used to compute the function values don't include the central value (see derivative_calculator.py at lines 55–66). This isn't difficult to fix and may in fact not be necessary, but it is good to be aware of this.

@nikosarcevic
Copy link
Owner

One thing I noticed is that the x_values used to compute the function values don't include the central value (see derivative_calculator.py at lines 55–66). This isn't difficult to fix and may in fact not be necessary, but it is good to be aware of this.

yeah I noticed it, probs because I was adding the gaussian noise to it. can fix it when I do the upgrade with the broadcasting etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants