Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue transferred to different repository is not being cleaned up #93

Closed
nikku opened this issue Nov 17, 2020 · 0 comments · Fixed by #101
Closed

Issue transferred to different repository is not being cleaned up #93

nikku opened this issue Nov 17, 2020 · 0 comments · Fixed by #101
Labels
bug Something isn't working

Comments

@nikku
Copy link
Owner

nikku commented Nov 17, 2020 •
edited
Loading

Describe the Bug

Issue is not being cleaned up if the repository is not accessible anymore (due to access restriction or transfer).

Steps to Reproduce

  1. create issue in repository org-1/A
  2. transfer repository to org-2/A
  3. see that issue is still on the board (cf. Support repository transfer #91)
  4. see that issue is not being cleaned up during background sync

Expected Behavior

The issue may temporarily be still on the board, however, it is cleaned up during background sync.

Environment

  • Host (Browser/Node version), if applicable: Any
  • OS: Any
  • Board version: v0.34.0
@nikku nikku added the bug Something isn't working label Nov 17, 2020
nikku added a commit that referenced this issue Nov 17, 2020
@nikku
fix(background-sync): remove open missing issues immediately
638250c 
All open, inaccessible issues shall be removed immediately upon
background sync.

This prevents issues hanging on the board that are now inaccessible to
the board.

Closes #93
nikku added a commit that referenced this issue Nov 17, 2020
@nikku
fix(background-sync): properly handle removed repositories
1c0dde7 
Keep track of accessible repositories during background sync
and remove all issues that do not belong to such repositories
immediately.

This prevents issues hanging on the board that are inaccessible
to the board due to ownership transfer or changed GitHub app
permissions.

Closes #93
nikku added a commit that referenced this issue Nov 17, 2020
@nikku
fix(background-sync): properly handle removed repositories
8413c4c 
Keep track of accessible repositories during background sync
and remove all issues that do not belong to such repositories
immediately.

This prevents issues hanging on the board that are inaccessible
to the board due to ownership transfer or changed GitHub app
permissions.

Closes #93
nikku added a commit that referenced this issue Nov 17, 2020
@nikku
fix(background-sync): properly handle removed repositories
164943e 
Keep track of accessible repositories during background sync
and remove all issues that do not belong to such repositories
immediately.

This prevents issues hanging on the board that are inaccessible
to the board due to ownership transfer or changed GitHub app
permissions.

Closes #93
nikku added a commit that referenced this issue Nov 17, 2020
@nikku
fix(background-sync): properly handle removed repositories
34da279 
Keep track of accessible repositories during background sync
and remove all issues that do not belong to such repositories
immediately.

This prevents issues hanging on the board that are inaccessible
to the board due to ownership transfer or changed GitHub app
permissions.

Closes #93
@nikku nikku mentioned this issue Nov 17, 2020
Merged
nikku added a commit that referenced this issue Nov 17, 2020
@nikku
fix(background-sync): properly handle removed repositories
f176a17 
Keep track of accessible repositories during background sync
and remove all issues that do not belong to such repositories
immediately.

This prevents issues hanging on the board that are inaccessible
to the board due to ownership transfer or changed GitHub app
permissions.

Closes #93
joannenolan-sky pushed a commit to joannenolan-sky/wuffle that referenced this issue Nov 30, 2020
@nikku
fix(background-sync): properly handle removed repositories
39c9b3f 
Keep track of accessible repositories during background sync
and remove all issues that do not belong to such repositories
immediately.

This prevents issues hanging on the board that are inaccessible
to the board due to ownership transfer or changed GitHub app
permissions.

Closes nikku#93
joannenolan-sky pushed a commit to joannenolan-sky/wuffle that referenced this issue Nov 30, 2020
@nikku
fix(background-sync): properly handle removed repositories
c86361e 
Keep track of accessible repositories during background sync
and remove all issues that do not belong to such repositories
immediately.

This prevents issues hanging on the board that are inaccessible
to the board due to ownership transfer or changed GitHub app
permissions.

Closes nikku#93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(background-sync): properly handle removed repositories nikku/wuffle
1 participant
@nikku