Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #101

Closed
22 of 23 tasks
nikdo opened this issue Jun 16, 2020 · 2 comments
Closed
22 of 23 tasks

Update dependencies #101

nikdo opened this issue Jun 16, 2020 · 2 comments
Labels

Comments

@nikdo
Copy link
Owner

nikdo commented Jun 16, 2020

  • update to latest react
    • check React changelog
  • update client dependencies
  • find out why nothing is diplayed on spot detail
  • test everything
    • autosuggest
    • search icon transition
    • routing
    • route transition
    • routing history
    • chart ticks alignment (see d3AxisOffset in constants)
  • update devDependencies
    • fix storybook
    • migrate storybook config
    • fix font in storybook
  • update API dependencies
    • find out how to test cache
    • upgrade make-fetch-happen
    • verify that caching works
    • test everything
  • publish
  • test chart scrolling and tooltip on mobile device
  • move cacache question to the new cacache repository location
@nikdo nikdo added the ½d label Jun 16, 2020
@nikdo
Copy link
Owner Author

nikdo commented Jun 22, 2020

Caching takeaways

Express res.json sends a 304 status code if the response hasn't changed. So querying spot detail on our API returns 304 if DarkSky returns the same response. DarkSky returns the same response only if it is cached because otherwise, it returns new data with each request.

This means that if 304 is logged as status code by express, the forecast is cached.

@nikdo
Copy link
Owner Author

nikdo commented Jun 22, 2020

Time estimated: 3h
Time spent: 11h

Why:

  • API caching verification after make-fetch-happen upgrade
  • fixing broken storybook
  • fixing linter issues after standard upgrade
  • investigating problem caused by history package bug

@nikdo nikdo closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant