Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBAC verbs #1

Open
aleksasiriski opened this issue Mar 25, 2024 · 4 comments
Open

RBAC verbs #1

aleksasiriski opened this issue Mar 25, 2024 · 4 comments

Comments

@aleksasiriski
Copy link

Why does this operator need patch verb on nodes? It just looks at all the nodes and sees if it has taint node.kubernetes.io/unreachable

Why does this operator need create verb on ciliumegressgatewaypolicies? It just patches the policies to use the working node if it has changed.

@nikatar
Copy link
Owner

nikatar commented Apr 9, 2024

Yes, it seems you are right.
This is an artifact from previous iterations. I've been doing this for a long time.
Now I don't use this operator in my work. But if you make a PR and test it, I'll accept it

@aleksasiriski
Copy link
Author

aleksasiriski commented Apr 9, 2024

I decided to make a fork but still haven't got around to testing it. If you like the changes I made I can contribute a PR.

@nikatar
Copy link
Owner

nikatar commented Apr 10, 2024

Yes, let's

@aleksasiriski
Copy link
Author

Sorry I haven't responded. Will be testing this in the next days and will make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants