-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting type error using the Rating field in Nova #18
Comments
Having same problem. |
Hi guys! any news? How did you fix it until the pull request get approved? Thanks |
I'm not using an alternative right now, I'm waiting and focusing on other parts of my development. The solutions that I see right now are:
|
@nikaia You should really accept this pull request, because your package is BROKEN on PHP8 because of a single In the mean time, until @nikaia accepts this pull request, you can use something like vendor-patches to patch this bug yourselves. |
Please can you update this bug ? |
I am getting the following error in PHP 8:
Type mixed cannot be marked as nullable since mixed already includes null at ./vendor/nikaia/nova-rating-field/src/Rating.php:43
I checked your file and the constructor signatures is
public function __construct(string $name, $attribute = null, ?mixed $resolveCallback = null)
and the offending part is?mixed
asmixed
already containsnull
, so no need to add the?
.The text was updated successfully, but these errors were encountered: