From 970c235e3e59ea22febbbe310518e43283c2314a Mon Sep 17 00:00:00 2001 From: Jimmy Belloche Date: Thu, 7 Jan 2021 15:02:48 +0100 Subject: [PATCH] iox-#454 fix review findings from PR Signed-off-by: Jimmy Belloche --- iceoryx_posh/test/moduletests/test_roudi_memory_block.cpp | 4 ++-- iceoryx_posh/test/moduletests/test_roudi_memory_provider.cpp | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/iceoryx_posh/test/moduletests/test_roudi_memory_block.cpp b/iceoryx_posh/test/moduletests/test_roudi_memory_block.cpp index 09c09dfe7b..efe1de13b6 100644 --- a/iceoryx_posh/test/moduletests/test_roudi_memory_block.cpp +++ b/iceoryx_posh/test/moduletests/test_roudi_memory_block.cpp @@ -59,8 +59,8 @@ class MemoryBlock_Test : public Test { } - static constexpr uint64_t MEMORY_SIZE = 1; - static constexpr uint64_t MEMORY_ALIGNMENT = 1; + static constexpr uint64_t MEMORY_SIZE = 1U; + static constexpr uint64_t MEMORY_ALIGNMENT = 1U; MemoryBlockMock sut; MemoryProviderTestImpl memoryProvider; diff --git a/iceoryx_posh/test/moduletests/test_roudi_memory_provider.cpp b/iceoryx_posh/test/moduletests/test_roudi_memory_provider.cpp index 6adadb88e1..34d5d3ed72 100644 --- a/iceoryx_posh/test/moduletests/test_roudi_memory_provider.cpp +++ b/iceoryx_posh/test/moduletests/test_roudi_memory_provider.cpp @@ -12,9 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. -//#define protected public #include "iceoryx_posh/roudi/memory/memory_provider.hpp" -//#undef protected #include "iceoryx_utils/internal/relocatable_pointer/relative_ptr.hpp" @@ -349,7 +347,7 @@ TEST_F(MemoryProvider_Test, SegmentIdValueAfterDestructionIsUnset) TEST_F(MemoryProvider_Test, GetErrorString) { - for(int16_t i = 0; i < nTestCase;i++) + for(int16_t i = 0; i < nTestCase; i++) { const char * result = MemoryProviderFailingCreation::getErrorStringMemoryProvider(m_testCombinationMemoryProviderError[i]); EXPECT_THAT(*result, Eq(*m_testResultGetErrorString[i]));