Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pennsieve Download file API #14

Closed
hsorby opened this issue May 19, 2023 · 1 comment
Closed

Pennsieve Download file API #14

hsorby opened this issue May 19, 2023 · 1 comment

Comments

@hsorby
Copy link
Contributor

hsorby commented May 19, 2023

sparc.client/src/sparc/client/services/pennsieve.py

Line 292 in e76a75e

def download_file(self, file_list: dict, output_name: str = None):

The download file API could be improved. The files_list parameter takes a dict which is misleading at best. Also, the list_files API returns a list it seems sensible to change the files_list parameter to take a list.
@athril athril mentioned this issue May 30, 2023
Merged
@athril
Copy link
Collaborator

athril commented Jun 1, 2023

Closed with PR #16

@athril athril closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hsorby @athril