fix: assertion failure in new Elem API leads to unhandledRejection. #4277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if we create a test case using an async callback but do not use
await
anywhere inside the test case, failure of the newly introduced assertions in the new Element API leads tounhandledRejection
:With this PR, assertion failures will gracefully end the test instead of raising
unhandledRejection
which abruptly ends the test run.Caveat
If we use
then()
with the assertion promises, assertion failure leads tounhandledRejection
. But usingthen()
inside an async function is not common, nor is usingthen()
on any normal Nightwatch command or assertion.