fix: frame command overlapping with subsequent NW commands. #4276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
.frame()
command is used withawait
(as shown below), the command promise resolves early before the command can even find the target frame element. Due to this, the subsequent Nightwatch commands start running parallelly with the.frame()
command.This PR solves this issue by ensuring that the
frame()
command promise is only resolved once the command has completed its execution so that the subsequent commands only run after that.