Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selector and error line for "staleElementReferenceError" #4214

Merged

Conversation

pujagani
Copy link
Member

@pujagani pujagani commented May 30, 2024

Fixes #4184

Adds selector and error line with proper formatting for "StaleElementReferenceError" and other errors that might occur when working with elements.

Since this updates the logs displayed, adding a test for it is hard. Instead, the PR adds an example to showcase the fix.

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Before marking your PR for review, please test and verify your changes by making appropriate modifications to any of the Nightwatch example tests (present in examples/tests directory of the project) and running them. ecosia.js and duckDuckGo.js are good examples to work with.
  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;

The changes now display the logs as follows:
Screenshot 2024-05-30 at 8 12 00 PM

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@AutomatedTester AutomatedTester merged commit 23df1db into nightwatchjs:main Sep 17, 2024
15 of 17 checks passed
garg3133 added a commit that referenced this pull request Oct 25, 2024
garg3133 added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stale element reference errors should report the element and/or line of code it considers stale
3 participants