Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate utils modules to TS. #3869

Merged
merged 13 commits into from
Aug 22, 2023
Merged

Migrate utils modules to TS. #3869

merged 13 commits into from
Aug 22, 2023

Conversation

garg3133
Copy link
Member

@garg3133 garg3133 commented Aug 8, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

vaibhavsingh97
vaibhavsingh97 requested changes Aug 9, 2023
View reviewed changes
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make a few refactors and have provided some suggestions for changes.

lib/utils/isErrorObject.ts Outdated Show resolved Hide resolved
lib/utils/getFreePort.ts Outdated Show resolved Hide resolved
lib/utils/getFreePort.ts Show resolved Hide resolved
lib/utils/nightwatchInterfaces.ts Outdated Show resolved Hide resolved
lib/utils/browsername.ts Outdated Show resolved Hide resolved
lib/utils/alwaysDisplayError.ts Outdated Show resolved Hide resolved
lib/utils/addDetailedError.ts Outdated Show resolved Hide resolved
vaibhavsingh97
vaibhavsingh97 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! The changes look good to me. 🙌

@garg3133 garg3133 mentioned this pull request Aug 20, 2023
Open
17 tasks
@AutomatedTester AutomatedTester merged commit 79367cd into nightwatchjs:main Aug 22, 2023
16 checks passed
@garg3133 garg3133 deleted the utils-migration branch August 22, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravityvi gravityvi gravityvi approved these changes

@vaibhavsingh97 vaibhavsingh97 vaibhavsingh97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garg3133 @vaibhavsingh97 @gravityvi @AutomatedTester