Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frame() command doesn't support page object element #3655

Open
tim-yao opened this issue Mar 25, 2023 · 6 comments
Open

frame() command doesn't support page object element #3655

tim-yao opened this issue Mar 25, 2023 · 6 comments

Comments

@tim-yao
Copy link
Contributor

tim-yao commented Mar 25, 2023

Description of the bug/issue

When I use frame() command, I expect the page object element can be used as a selector, but actually, it won't work.

Steps to reproduce

Try using frame() with a page object element.

Sample test

myPage.api.frame('@myIframe')

Nightwatch.js Version

2.6.14

Additional Information

See Discord discussion https://discord.com/channels/618399631038218240/1088668054650626058

David Burns - AutomatedTester — Yesterday at 21:33
I think this might need a bug raised. That doesn't seem right
andrei — Today at 01:42
when using page objects, elements passed to commands on the .api namespace aren't resolved automatically.
but we can easily add the frame() command on the main page object namespace
Currently .frame() is implemented as a "protocol" command, so we will need to move it to the element-commands and update the implementation as needed. It's a relatively straightforward task.

@yashPratp983
Copy link
Contributor

I want to work on this issue.

@skushagra9
Copy link

I am interested to work on this issue

@SuperexMack
Copy link

can i work on this issue ? , i am new to open source but i will try my best to fix it

@nikhil-babar
Copy link

Could you please assign this issue to me, @garg3133?

@divine7022
Copy link

I am interested to work on this issue could you please assign me this issue.

@shah0108
Copy link

is this issue closed??

Harshit-7373 added a commit to Harshit-7373/nightwatch that referenced this issue Oct 29, 2024
frame() command doesn't support page object element nightwatchjs#3655.

github- harshit-7373
@Harshit-7373 Harshit-7373 mentioned this issue Oct 29, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants