Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: install avd #58

Merged
merged 9 commits into from
Aug 20, 2024
Merged

feat: install avd #58

merged 9 commits into from
Aug 20, 2024

Conversation

itsspriyansh
Copy link
Contributor

@itsspriyansh itsspriyansh commented Jul 31, 2024

Description

This PR

  1. Adds the support to create a new AVD using the installed system-images with the following command:
npx @nightwatch/mobile-helper android install --avd
  1. Adds a utility function called getInstalledSystemImageswhich fetches a list of installed system images in the computer.
Screencast.from.31-07-24.09.35.23.PM.IST.webm

@itsspriyansh
Copy link
Contributor Author

@garg3133 PR updated.

By the way, shall we keep the option --avd or use --emulator instead? Just like connect --emulator.

@garg3133
Copy link
Member

By the way, shall we keep the option --avd or use --emulator instead? Just like connect --emulator.

To me, even putting --avd under the install subcommand does not make much sense because we are not installing anything but "creating" a virtual device out of the things we've already installed. But I guess creating a new "create" subcommand just for this does not make much sense, so the "install" subcommand is fine for now.

Coming to your question, install --emulator might strike as if it will install the emulator software/binary which is not true here. The command is for creating an Android Virtual Device, so --avd is correct here.

Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb work on this, works brilliantly! Just need to do better error handling.

src/commands/android/subcommands/install/avd.ts Outdated Show resolved Hide resolved
src/commands/android/subcommands/install/avd.ts Outdated Show resolved Hide resolved
src/commands/android/subcommands/install/avd.ts Outdated Show resolved Hide resolved
src/commands/android/subcommands/install/avd.ts Outdated Show resolved Hide resolved
src/commands/android/subcommands/install/avd.ts Outdated Show resolved Hide resolved
src/commands/android/subcommands/install/avd.ts Outdated Show resolved Hide resolved
src/commands/android/subcommands/install/avd.ts Outdated Show resolved Hide resolved
src/commands/android/subcommands/install/avd.ts Outdated Show resolved Hide resolved
@itsspriyansh
Copy link
Contributor Author

@garg3133 PR updated

@garg3133 garg3133 merged commit ea0ffd0 into nightwatchjs:main Aug 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants