-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Eslint issues #44
Fix Eslint issues #44
Comments
hey @vaibhavsingh97 there are some variable types which set as any so those should be changed also ? |
Hello @vaibhavsingh97 , I have looked into the issue and removed the unused vars for this error
Please let me know which approach I should take? Also, will you please assign this issue to me? |
Hi, I was trying to solve this issue and while I was doing that I could remove most of the linting errors except a few (2 of them intentionally because I don't have a very deep understanding of the types in this repo). But just when I had build the project to test before opening the PR there seemed to be quite a few issues mainly with 2 files -
There seems to be an issue with the interfaces for IEnvironmentDropdownData and EnvironmentData I am open to discuss on this issue would really appreciate some suggestions before opening a PR. |
Hello @vaibhavsingh97 i had resolved this issued of ESling fixing issue in the new branch Ankuristic/Ankuristic:fixing_eslint_issue . please check and merge the issue |
hey @vaibhavsingh97 can I work on this?? |
@vaibhavsingh97 i would love to work on this issue. please assign it to me. |
Description
There are currently ESlint violations in the CI build for PRs, such as missing explicit any and unused vars,etc. We need to fix these issues
Steps to reproduce?
Run
npm lint
at root of the projectReferences
Sample build link: https://github.com/nightwatchjs/html-reporter/actions/runs/8119655363/job/22241267328?pr=42
The text was updated successfully, but these errors were encountered: