Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Eslint issues #44

Open
vaibhavsingh97 opened this issue Mar 4, 2024 · 6 comments · May be fixed by Ankuristic/html-reporter#1
Open

Fix Eslint issues #44

vaibhavsingh97 opened this issue Mar 4, 2024 · 6 comments · May be fixed by Ankuristic/html-reporter#1
Labels
good first issue Good for newcomers

Comments

@vaibhavsingh97
Copy link
Member

vaibhavsingh97 commented Mar 4, 2024

Description

There are currently ESlint violations in the CI build for PRs, such as missing explicit any and unused vars,etc. We need to fix these issues

Steps to reproduce?

Run npm lint at root of the project

npm run lint

References

Sample build link: https://github.com/nightwatchjs/html-reporter/actions/runs/8119655363/job/22241267328?pr=42

@vaibhavsingh97 vaibhavsingh97 added the good first issue Good for newcomers label Mar 4, 2024
@subhajit20
Copy link
Contributor

subhajit20 commented Mar 4, 2024

hey @vaibhavsingh97 there are some variable types which set as any so those should be changed also ?

@piyushmishra1416
Copy link

Hello @vaibhavsingh97 , I have looked into the issue and removed the unused vars for this error '_ctx' is defined but never used. But, what approach would be the correct fix for this warning Unexpected any. Specify a different type :-

  • adding proper suitable types in place of any.
  • alternatively, just put unknown in place of any to bypass the warnings.

Please let me know which approach I should take? Also, will you please assign this issue to me?

@AritraLeo
Copy link

Hi, I was trying to solve this issue and while I was doing that I could remove most of the linting errors except a few (2 of them intentionally because I don't have a very deep understanding of the types in this repo).

But just when I had build the project to test before opening the PR there seemed to be quite a few issues mainly with 2 files -

src/components/EnviornmentDropDown/index.tsx

src/components/Summary/utils.ts

There seems to be an issue with the interfaces for IEnvironmentDropdownData and EnvironmentData

I am open to discuss on this issue would really appreciate some suggestions before opening a PR.
Thanks!

@Ankuristic
Copy link

Hello @vaibhavsingh97 i had resolved this issued of ESling fixing issue in the new branch Ankuristic/Ankuristic:fixing_eslint_issue . please check and merge the issue

@Ankuristic Ankuristic linked a pull request Mar 23, 2024 that will close this issue
@95481
Copy link

95481 commented Jun 15, 2024

hey @vaibhavsingh97 can I work on this??

@VanshikaSabharwal
Copy link

@vaibhavsingh97 i would love to work on this issue. please assign it to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants