Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Typo Duration of Insulin Action default value #79

Open
ebouchut opened this issue Oct 3, 2024 · 5 comments
Open

✏️ Typo Duration of Insulin Action default value #79

ebouchut opened this issue Oct 3, 2024 · 5 comments

Comments

@ebouchut
Copy link
Contributor

ebouchut commented Oct 3, 2024

Describe the error**

I noticed the default value of Duration of Insulin Action is 5in the documentation whereas I see 6 in my configuration.
I don't recall changing this value, so 6 should be the default value.

https://docs.diy-trio.org/en/latest/settings/configuration/pumpsettings.html#duration-of-insulin-action

Screenshots

CleanShot 2024-10-03 at 20 13 10@2x

@bjornoleh
Copy link
Contributor

The minimum is 5 hours, and 5 hours has been used as default in bothOpenAPS and AAPS, it seems:

https://androidaps.readthedocs.io/en/latest/Configuration/Config-Builder.html#dia

https://openaps.readthedocs.io/en/latest/docs/Customize-Iterate/optimize-your-settings.html?highlight=Dia#frequent-negative-iob-at-the-same-time-every-day

But 6 hours is probably a better default, which is also used in Loop.

@ebouchut
Copy link
Contributor Author

ebouchut commented Oct 3, 2024

Thanks for shedding my light and sharing the links.
I therefore changed it.

Sorry for the noise.

@ebouchut ebouchut closed this as completed Oct 3, 2024
@MikePlante1
Copy link
Contributor

This is still a valid Issue. The default in Trio is 6 hours. Looking back through GitHub, it looks like it got changed to 6 from 5 just before the iAPS repo was opened.

@MikePlante1 MikePlante1 reopened this Oct 3, 2024
@ebouchut
Copy link
Contributor Author

ebouchut commented Oct 4, 2024

ℹ️ Another section to update in this case is Insulin Curve.

@LiroyvH
Copy link

LiroyvH commented Oct 5, 2024

Wonder if this ought to be made insulin dependent to some extent. Lyumjev seems to have a shorter tail than Humalog, Novorapid and Fiasp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants